From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: mfd: lm3533: Remove driver specific regmap wrappers Date: Thu, 04 Jun 2026 13:59:53 +1000 Message-ID: In-Reply-To: <20260601151831.76350-3-clamor95@gmail.com> References: <20260601151831.76350-1-clamor95@gmail.com> <20260601151831.76350-3-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Bug: Swapped mask/val in lm3533_als_set_int_mode.** The old `lm3533_update(lm3533, reg, val, mask)` wrapper internally calls `r= egmap_update_bits(regmap, reg, mask, val)` =E2=80=94 the wrapper takes `(va= l, mask)` while regmap takes `(mask, val)`. Most call sites are converted c= orrectly, but one is not: ```c - ret =3D lm3533_update(als->lm3533, LM3533_REG_ALS_ZONE_INFO, val, mask); + ret =3D regmap_update_bits(als->lm3533->regmap, LM3533_REG_ALS_ZONE_INFO, + val, mask); ``` This should be `mask, val` (not `val, mask`). When `enable=3Dfalse`, `val= =3D0` and `mask=3DLM3533_ALS_INT_ENABLE_MASK`. The direct call becomes `reg= map_update_bits(regmap, reg, 0, mask)` =E2=80=94 a mask of 0 means no bits = are touched, so disabling ALS interrupts becomes a no-op. The correct conve= rsion is: ```c ret =3D regmap_update_bits(als->lm3533->regmap, LM3533_REG_ALS_ZONE_INFO, mask, val); ``` All other `lm3533_update` =E2=86=92 `regmap_update_bits` conversions in thi= s patch are correct. The `u8` =E2=86=92 `u32` type changes for regmap_read output pointers are c= orrect and necessary since `regmap_read` requires `unsigned int *`. --- Generated by Claude Code Patch Reviewer