From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/connector: Add HDMI 2.0 scrambler infrastructure Date: Thu, 04 Jun 2026 13:33:47 +1000 Message-ID: In-Reply-To: <20260602-dw-hdmi-qp-scramb-v7-2-445eb54ee1ed@collabora.com> References: <20260602-dw-hdmi-qp-scramb-v7-0-445eb54ee1ed@collabora.com> <20260602-dw-hdmi-qp-scramb-v7-2-445eb54ee1ed@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Minor concern: `INIT_DELAYED_WORK(&connector->hdmi.scdc_work, ...)` is call= ed in `drm_connector_init_only()` which runs for **every** connector type (= DP, LVDS, DSI, etc.), not just HDMI connectors. The overhead is small (just= zeroes the struct), but it would be cleaner to move this initialization in= to `drmm_connector_hdmi_init()` where the HDMI-specific setup belongs. The `scdc_cb` function pointer pattern is a bit unusual =E2=80=94 it's set = by the framework at runtime rather than via a vtable. The comment documents= this, but it means `scdc_cb` can be NULL when the work fires. The NULL che= ck in `drm_connector_hdmi_scdc_work()` handles this safely. --- Generated by Claude Code Patch Reviewer