From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/mdss: Add Shikra support Date: Thu, 04 Jun 2026 11:45:50 +1000 Message-ID: In-Reply-To: <20260603-shikra-display-v1-2-aeac1b94faa7@oss.qualcomm.com> References: <20260603-shikra-display-v1-0-aeac1b94faa7@oss.qualcomm.com> <20260603-shikra-display-v1-2-aeac1b94faa7@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch adds one-line match table entries in two files. **Sorting issue in `dpu_kms.c`**: The new entry is inserted between `qcom,s= dm845-dpu` and `qcom,sc7180-dpu`: ```c { .compatible =3D "qcom,sdm845-dpu", .data =3D &dpu_sdm845_cfg, }, + { .compatible =3D "qcom,shikra-dpu", .data =3D &dpu_qcm2290_cfg, }, { .compatible =3D "qcom,sc7180-dpu", .data =3D &dpu_sc7180_cfg, }, ``` The existing table is largely alphabetically sorted (confirmed by checking = the tree =E2=80=94 it runs `eliza`, `glymur`, `kaanapali`, `msm8917`, ... `= qcm2290`, `sa8775p`, `sar2130p`, `sdm630`, `sdm660`, `sdm670`, `sdm845`, th= en anomalously `sc7180`, `sc7280`, `sc8180x`, ...). The `shikra` entry shou= ld go after the `sc8280xp-dpu` entry and before `sm6115-dpu` (since `"sc" <= "sh" < "sm"` alphabetically). Currently it perpetuates the existing `sdm/s= c` sort anomaly. **Same issue in `msm_mdss.c`**: The entry goes between `sdm845-mdss` and `s= c7180-mdss`, matching the same anomaly. The correct position would be betwe= en `sc8280xp-mdss` and `sm6115-mdss`. **If fallback compatibles are adopted** (per Patch 1 feedback), neither of = these driver changes would be needed. --- Generated by Claude Code Patch Reviewer