From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Clear queue->active_job when v3d_fence_create() fails Date: Thu, 04 Jun 2026 11:24:39 +1000 Message-ID: In-Reply-To: <20260603-v3d-sched-misc-fixes-v3-2-d7114bba55a0@igalia.com> References: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> <20260603-v3d-sched-misc-fixes-v3-2-d7114bba55a0@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good bugfix. Previously, if `v3d_fence_create()` failed, `queue->active_job` was left as a dangling pointer. The patch consolidates the early-return and fence-failure paths into a single `out_clean_job` label per function. The BIN path correctly takes `queue->queue_lock` around the clear (because `v3d_overflow_mem_work()` can race), while RENDER/TFU/CSD paths clear lock-free (no concurrent reader). This distinction is well-documented in the commit message and correct. Reviewed-by: Tvrtko Ursulin. No issues. --- Generated by Claude Code Patch Reviewer