From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: visionox-vtdr6130: switch to devm panel calls and drop remove Date: Fri, 05 Jun 2026 06:24:33 +1000 Message-ID: In-Reply-To: <20260604-topic-sm8x50-vtdr6130-dsc-v1-2-09bcd1dff1fb@linaro.org> References: <20260604-topic-sm8x50-vtdr6130-dsc-v1-0-09bcd1dff1fb@linaro.org> <20260604-topic-sm8x50-vtdr6130-dsc-v1-2-09bcd1dff1fb@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch converts `drm_panel_add()` + `mipi_dsi_attach()` to their devm-m= anaged equivalents and removes the now-unnecessary `remove()` callback. **Probe changes:** ```c - drm_panel_add(&ctx->panel); - - ret =3D mipi_dsi_attach(dsi); - if (ret < 0) { - dev_err(dev, "Failed to attach to DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); + ret =3D devm_drm_panel_add(dev, &ctx->panel); + if (ret) return ret; - } - - return 0; + + return devm_mipi_dsi_attach(dev, dsi); ``` Clean conversion. The devm ordering is correct =E2=80=94 `devm_drm_panel_ad= d()` is called first, so on teardown the DSI detach (registered second) wil= l happen before the panel removal. This matches the manual teardown order i= n the old `remove()` callback. The error path simplification (dropping `drm= _panel_remove` on attach failure) is correct since devm handles it. **Remove callback deletion:** ```c -static void visionox_vtdr6130_remove(struct mipi_dsi_device *dsi) -{ - ... -} ``` and ```c static struct mipi_dsi_driver visionox_vtdr6130_driver =3D { .probe =3D visionox_vtdr6130_probe, - .remove =3D visionox_vtdr6130_remove, ``` Both `devm_drm_panel_add()` and `devm_mipi_dsi_attach()` are available in t= he tree (confirmed in headers). This is a standard cleanup seen across many= panel drivers. **Verdict:** Correct, clean conversion. No issues. --- Generated by Claude Code Patch Reviewer