From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: libfs: drop redundant SB_I_NOEXEC/SB_I_NODEV in init_pseudo() callers Date: Fri, 05 Jun 2026 06:45:31 +1000 Message-ID: In-Reply-To: <20260604025315.245910-3-jhubbard@nvidia.com> References: <20260604025315.245910-1-jhubbard@nvidia.com> <20260604025315.245910-3-jhubbard@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good.** This is a pure cleanup removing 10 lines across 6 files. All removals are c= orrect: | File | What was removed | Correct? | |------|-----------------|----------| | `fs/aio.c` | `SB_I_NOEXEC` | Yes =E2=80=94 now set by `init_pseudo()` | | `fs/anon_inodes.c` | `SB_I_NOEXEC` + `SB_I_NODEV` | Yes | | `fs/nsfs.c` | `SB_I_NOEXEC \| SB_I_NODEV` | Yes | | `fs/pidfs.c` | `SB_I_NOEXEC` + `SB_I_NODEV` | Yes | | `mm/secretmem.c` | `SB_I_NOEXEC` + `SB_I_NODEV` | Yes | | `virt/kvm/guest_memfd.c` | `SB_I_NOEXEC` + `SB_I_NODEV` | Yes | I verified all 6 callers in the applied tree =E2=80=94 none retain any `SB_= I_NOEXEC` or `SB_I_NODEV` assignments after `init_pseudo()`, confirming the= removals are complete and correct. The patch intentionally does **not** carry a `Fixes:` tag or `Cc: stable`, = which is correct since it's a no-op cleanup that depends on patch 1. --- Generated by Claude Code Patch Reviewer