public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] gpu: Fix uninitialized buddy for built-in drivers
Date: Mon, 23 Feb 2026 06:25:10 +1000	[thread overview]
Message-ID: <review-patch2-77fc0550-cbb4-4796-85ea-c552e12125c1@nvidia.com> (raw)
In-Reply-To: <77fc0550-cbb4-4796-85ea-c552e12125c1@nvidia.com>

Patch Review

> -module_init(drm_sched_fence_slab_init);
> +subsys_initcall(drm_sched_fence_slab_init);

This fixes a latent issue. The scheduler fence slab init allocates a `kmem_cache` that must exist before any driver creates scheduler fences. Currently this works because `sched_fence.c` is linked within `drivers/gpu/drm/scheduler/` which is linked before the driver subdirectories. No actual regression has been reported.

The `Fixes:` tag points to `4983e48c85392` ("drm/sched: move fence slab handling to module init/exit") which is the commit that introduced the `module_init()` for the slab. The `Cc: stable` tag is questionable here since this has never caused an actual failure -- Greg KH explicitly asked why this is tagged for stable if it doesn't fix a real issue. The commit message says "This happened to work correctly so far due to the order of linking" which is accurate but doesn't justify stable backporting.

No code correctness issues in the change itself.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-02-22 20:25 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 15:20 [PATCH] gpu: Fix uninitialized buddy for built-in drivers Koen Koning
2026-02-13 17:27 ` Joel Fernandes
2026-02-16 10:28   ` Matthew Auld
2026-02-22 20:25     ` Claude review: " Claude Code Review Bot
2026-02-22 20:25   ` Claude Code Review Bot [this message]
2026-02-16 11:19 ` [PATCH v2] " Koen Koning
2026-02-16 21:31   ` Joel Fernandes
2026-02-19 10:16   ` Danilo Krummrich
2026-02-19 10:38     ` Matthew Auld
2026-02-19 11:14       ` Danilo Krummrich
2026-02-19 12:44         ` Matthew Auld
2026-02-19 12:56           ` Danilo Krummrich
2026-02-19 15:32             ` Matthew Auld
2026-02-19 16:08               ` Danilo Krummrich
2026-02-19 18:28             ` Koen Koning
2026-02-19 18:34               ` Danilo Krummrich
2026-02-19 21:38   ` [PATCH v3 0/3] gpu: fix module_init() usage Koen Koning
2026-02-19 21:38     ` [PATCH v3 1/3] gpu/buddy: " Koen Koning
2026-02-20  6:06       ` Greg KH
2026-02-20 10:17         ` Danilo Krummrich
2026-02-20 13:55           ` Joel Fernandes
2026-02-21  5:44             ` Greg KH
2026-02-19 21:38     ` [PATCH v3 2/3] drm/sched: " Koen Koning
2026-02-20  6:06       ` Greg KH
2026-02-19 21:38     ` [PATCH v3 3/3] drm/drv: " Koen Koning
2026-02-22 20:25     ` Claude review: gpu: " Claude Code Review Bot
2026-02-22 20:25 ` Claude review: gpu: Fix uninitialized buddy for built-in drivers Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-77fc0550-cbb4-4796-85ea-c552e12125c1@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox