From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] gpu: Fix uninitialized buddy for built-in drivers Date: Mon, 23 Feb 2026 06:25:10 +1000 Message-ID: In-Reply-To: <77fc0550-cbb4-4796-85ea-c552e12125c1@nvidia.com> References: <20260219213858.370675-1-koen.koning@linux.intel.com> <77fc0550-cbb4-4796-85ea-c552e12125c1@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review > -module_init(drm_sched_fence_slab_init); > +subsys_initcall(drm_sched_fence_slab_init); This fixes a latent issue. The scheduler fence slab init allocates a `kmem_cache` that must exist before any driver creates scheduler fences. Currently this works because `sched_fence.c` is linked within `drivers/gpu/drm/scheduler/` which is linked before the driver subdirectories. No actual regression has been reported. The `Fixes:` tag points to `4983e48c85392` ("drm/sched: move fence slab handling to module init/exit") which is the commit that introduced the `module_init()` for the slab. The `Cc: stable` tag is questionable here since this has never caused an actual failure -- Greg KH explicitly asked why this is tagged for stable if it doesn't fix a real issue. The commit message says "This happened to work correctly so far due to the order of linking" which is accurate but doesn't justify stable backporting. No code correctness issues in the change itself. --- Generated by Claude Code Patch Reviewer