From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH v2] staging: fbtft: fb_ra8875: replace udelays with fsleep
Date: Fri, 27 Feb 2026 12:54:37 +1000 [thread overview]
Message-ID: <review-patch2-aZ_6QvJPZplh6xtd@smile.fi.intel.com> (raw)
In-Reply-To: <aZ_6QvJPZplh6xtd@smile.fi.intel.com>
Patch Review
**Status**: Looks good.
The v2 patch correctly uses `fsleep(100)` which is the kernel's recommended flexible sleep API. For a 100us delay, `fsleep()` will internally choose `usleep_range()` (since 100us falls in the 10us–20ms range where `usleep_range` is preferred), so the end result is essentially the same as v1 but without the caller needing to pick the range bounds.
```c
- udelay(100);
+ fsleep(100);
```
Both replacements are in `write_reg8_bus8()`, which is clearly a sleepable context — it calls `par->fbtftops.write()` (an SPI transfer function) both before and after the delays.
**Minor observations:**
- The commit message and changelog are well-written and explain the rationale clearly.
- The `v2:` changelog below the `---` line properly documents what changed between versions.
**Reviewed-by worthy**: Yes, this is a straightforward and correct cleanup. No issues found.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-27 2:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 20:45 [PATCH] staging: fbtft: fb_ra8875: replace udelays with usleep_range Jose A. Perez de Azpillaga
2026-02-25 21:14 ` Greg KH
2026-02-27 2:43 ` Claude review: " Claude Code Review Bot
2026-02-27 2:54 ` Claude Code Review Bot
2026-02-25 23:40 ` [PATCH v2] staging: fbtft: fb_ra8875: replace udelays with fsleep Jose A. Perez de Azpillaga
2026-02-26 7:46 ` Andy Shevchenko
2026-02-26 8:31 ` Jose A. Perez de Azpillaga
2026-02-27 2:54 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-aZ_6QvJPZplh6xtd@smile.fi.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox