From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: novatek-nt36523: use devm_drm_panel_add() Date: Mon, 25 May 2026 16:58:17 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good** The change replaces: ```c drm_panel_add(&pinfo->panel); ``` with: ```c ret =3D devm_drm_panel_add(dev, &pinfo->panel); if (ret) return ret; ``` It also removes the entire `nt36523_remove()` callback and its `.remove` as= signment in the driver struct. This is correct because `nt36523_probe()` us= es `devm_mipi_dsi_attach()` for DSI attachment, so both DSI detach and pane= l removal are fully managed by devres. There is no remaining manual cleanup= , so the remove callback is no longer needed. The devres ordering is correct: `devm_drm_panel_add()` is registered before= `devm_mipi_dsi_attach()`, so during teardown the DSI devices will be detac= hed before the panel is removed from the registry. This is the right order = =E2=80=94 consumers (DSI hosts) should be disconnected before the panel dis= appears. The `Fixes:` tag correctly points to commit `0993234a0045` which introduced= the driver with the original `drm_panel_add()` call. --- Generated by Claude Code Patch Reviewer