From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: Add BAR1 aperture type and size constant
Date: Fri, 27 Feb 2026 14:25:32 +1000
Message-ID: <review-patch20-20260224225323.3312204-21-joelagnelf@nvidia.com>
In-Reply-To: <20260224225323.3312204-21-joelagnelf@nvidia.com>
References: <20260224225323.3312204-1-joelagnelf@nvidia.com> <20260224225323.3312204-21-joelagnelf@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Trivial. `BAR1_SIZE = SZ_256M` hardcoded -- the actual BAR1 size from PCI config may differ. Patch 23 later uses `pdev.resource_len(1)?` for the actual size, so this constant may only be used as the `pci::Bar<N>` type parameter (for MMIO mapping size). Worth verifying this matches hardware.

---
Generated by Claude Code Patch Reviewer