From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: Add helper for AS SDP transmission time selection Date: Sun, 12 Apr 2026 12:51:29 +1000 Message-ID: In-Reply-To: <20260408084239.1295325-21-ankit.k.nautiyal@intel.com> References: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> <20260408084239.1295325-21-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **R-b: Ville Syrjala** Adds `intel_dp_as_sdp_transmission_time()` which currently returns `DP_PR_AS_SDP_SETUP_TIME_T1` unconditionally, and `get_pr_alpm_as_sdp_transmission_time()` which maps this to the HW register field. The `intel_dp_as_sdp_transmission_time()` function takes no parameters and always returns T1. The code is structured for future expansion but currently trivial. The `crtc_state` parameter in `get_pr_alpm_as_sdp_transmission_time()` is unused -- it's presumably kept for future use. No functional issues. --- Generated by Claude Code Patch Reviewer