Claude review: drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM

Claude Code Review Bot
2026-04-12T02:51:29Z

Patch Review

Extends `intel_dp_link_training_set_mode()` with a `pr_with_as_sdp_enable` parameter to set `DP_FIXED_VTOTAL_AS_SDP_EN_IN_PR_ACTIVE` in DPCD 0x107. Updates all callers.

The condition in `intel_dp_update_downspread_ctrl()`:
```c
bool pr_with_as_sdp_enable =
intel_psr_needs_alpm_aux_less(intel_dp, crtc_state) &&
crtc_state->infoframes.enable & intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);
```

Missing parentheses around the `&` expression could be confusing since `&` has lower precedence than `&&`. While it evaluates correctly due to the left-to-right evaluation and the bitwise result being implicitly converted to bool, adding explicit parentheses would improve readability:
```c
(crtc_state->infoframes.enable & intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC))
```

Missing R-b.