Claude review: drm/i915/display: Add helper for AS SDP transmission time selection

Claude Code Review Bot
2026-03-11T20:55:30Z

Patch Review

Adds `intel_dp_as_sdp_transmission_time()` which always returns `DP_PR_AS_SDP_SETUP_TIME_T1`, and `get_pr_alpm_as_sdp_transmission_time()` to translate it to hardware register values.

**Design concern:** `intel_dp_as_sdp_transmission_time()` takes no parameters and always returns T1. This is essentially a constant masquerading as a function. A `#define` or an inline returning a constant would be clearer. The commit message says "future PR/AS SDP modes/features may require T2 or dynamic selection" but designing for hypothetical requirements adds unnecessary indirection. Also, the `crtc_state` parameter to `get_pr_alpm_as_sdp_transmission_time()` is unused.