Claude review: drm/i915/dp: Use revision field of AS SDP data structure

Claude Code Review Bot
2026-04-12T02:51:27Z

Patch Review

**R-b: Ville Syrjala**

Moves the AS SDP revision from hardcoded `0x02` to `as_sdp->revision`, sets it during compute, and reads it back during unpack. Also adds `revision` to the comparison function.

The removal of the revision check in unpack is notable:
```c
- if (sdp->sdp_header.HB2 != 0x02)
- return -EINVAL;
```
This makes the unpack accept any revision, which is necessary for forward compatibility but means the driver won't reject AS SDPs with unknown revisions during readback verification. This is reasonable since the purpose of the readback is comparison with what was programmed, not validation.

No issues.