From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tests: hdmi: Add tests for the color_format property Date: Sun, 12 Apr 2026 11:01:44 +1000 Message-ID: In-Reply-To: <20260409-color-format-v12-20-ce84e1817a27@collabora.com> References: <20260409-color-format-v12-0-ce84e1817a27@collabora.com> <20260409-color-format-v12-20-ce84e1817a27@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds parameterized KUnit tests for the HDMI color format property. Tests both the normal case (all formats supported, preferred mode) and the 420-only case (only YUV420 should succeed). The test structure is clean with `struct color_format_test_param` and `KUNIT_ARRAY_PARAM_DESC`. The tests verify both the return value and the resulting `output_format`. Existing tests are extended to assert `color_format == AUTO` where relevant, which strengthens the baseline. R-b from Maxime Ripard. **Verdict**: Good. --- --- Generated by Claude Code Patch Reviewer