From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Merge top and bottom half IRQ handlers Date: Sat, 16 May 2026 16:21:46 +1000 Message-ID: In-Reply-To: <20260510124111.1226584-21-jonas@kwiboo.se> References: <20260510124111.1226584-1-jonas@kwiboo.se> <20260510124111.1226584-21-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Since the bottom half now only calls `mod_delayed_work()` (which is safe from hardirq context), the threaded IRQ is no longer needed: ```c - ret = devm_request_threaded_irq(dev, irq, dw_hdmi_hardirq, - dw_hdmi_irq, IRQF_SHARED, - dev_name(dev), hdmi); + ret = devm_request_irq(dev, irq, dw_hdmi_hardirq, IRQF_SHARED, + dev_name(dev), hdmi); ``` The merged handler now masks with `HDMI_IH_PHY_STAT0_HPD` upfront: ```c + intr_stat = hdmi_readb(hdmi, HDMI_IH_PHY_STAT0) & HDMI_IH_PHY_STAT0_HPD; ``` Only the HPD bit is cleared in the sticky register, which is correct since RX_SENSE is fully masked after patch 17. The mute/unmute dance within the HPD block is preserved correctly. --- Generated by Claude Code Patch Reviewer