From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge_connector: Convert to atomic_create_state Date: Sat, 16 May 2026 13:22:56 +1000 Message-ID: In-Reply-To: <20260512-drm-mode-config-init-v4-20-591dfdcc1bf9@kernel.org> References: <20260512-drm-mode-config-init-v4-0-591dfdcc1bf9@kernel.org> <20260512-drm-mode-config-init-v4-20-591dfdcc1bf9@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Converts bridge_connector from `reset` to `atomic_create_state`. The new `d= rm_bridge_connector_create_state()` calls `drm_atomic_helper_connector_crea= te_state()` and conditionally applies HDMI init. Clean conversion. Note that removing `.reset` means the connector has no way to handle `drm_m= ode_config_reset()` for suspend/resume =E2=80=94 it relies on the new `atom= ic_create_state` fallback added in patch 15's `drm_mode_config_reset()` cha= nges. This is correct. No issues. --- **Summary:** The series is solid overall. The one real issue is the **missi= ng `drm_connector_list_iter_end()` on error path in patch 16** (`drm_mode_c= onfig_create_initial_state`). Everything else is clean, well-documented, an= d logically ordered. --- Generated by Claude Code Patch Reviewer