From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: ubwc: drop macrotile_mode from the database Date: Mon, 09 Mar 2026 08:32:19 +1000 Message-ID: In-Reply-To: <20260306-ubwc-rework-v1-21-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> <20260306-ubwc-rework-v1-21-9cfdff12f2bb@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes `macrotile_mode` from the struct. The `qcom_ubwc_macrotile_mode()` helper now derives this from the UBWC version: ```c + return cfg->ubwc_enc_version >= UBWC_3_1; ``` The SoC configs that had `macrotile_mode = true` are all UBWC 3.1+ (sc7280, sar2130p, etc.), confirming the version-based derivation is correct. --- Generated by Claude Code Patch Reviewer