From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: use HRT lifetime for Bar
Date: Tue, 28 Apr 2026 13:47:59 +1000
Message-ID: <review-patch21-20260427221155.2144848-22-dakr@kernel.org>
In-Reply-To: <20260427221155.2144848-22-dakr@kernel.org>
References: <20260427221155.2144848-1-dakr@kernel.org> <20260427221155.2144848-22-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

The self-referential pattern is the main concern:
```rust
Ok(try_pin_init!(NovaCore {
    bar: pdev.iomap_region_sized::<BAR0_SIZE>(0, c"nova-core/bar0")?,
    gpu <- Gpu::new(pdev, unsafe { &*core::ptr::from_ref(bar) }),
    ...
}))
```
This relies on `try_pin_init!` initializing fields in declaration order and `bar` being at a pinned stable address. The TODO comment acknowledges this needs the upcoming self-referential pin-init support. This is marked as REF (reference) so it's not intended for merging as-is. Acceptable as a demonstration, but should not be merged without the pin-init support.

The simplification of `Gpu::unbind()` and removal of `Arc<Devres<Bar0>>` is a clear win.

---
Generated by Claude Code Patch Reviewer