From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: net: renesas: rswitch: include PHY provider header Date: Tue, 05 May 2026 10:35:05 +1000 Message-ID: In-Reply-To: <20260430110652.558622-22-vladimir.oltean@nxp.com> References: <20260430110652.558622-1-vladimir.oltean@nxp.com> <20260430110652.558622-22-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The commit message here is excellent documentation of a fundamentally broke= n API usage pattern. The rswitch driver accesses `phy->power_count` without= locking (the field is protected by `phy->mutex`), and works around a lazy = PHY provider implementation by power-cycling the PHY. The `/* FIXME */` include is the right pragmatic choice =E2=80=94 fixing th= e actual issue requires rethinking both the consumer and provider drivers. Reviewed-by: Geert Uytterhoeven. This is good defensive flagging. --- Generated by Claude Code Patch Reviewer