From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Drop call to drm_bridge_hpd_notify() Date: Sat, 16 May 2026 16:21:46 +1000 Message-ID: In-Reply-To: <20260510124111.1226584-22-jonas@kwiboo.se> References: <20260510124111.1226584-1-jonas@kwiboo.se> <20260510124111.1226584-22-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes the redundant `drm_bridge_hpd_notify()` call from `dw_hdmi_hpd_work()`, keeping only `drm_helper_hpd_irq_event()`. The commit message provides excellent detail with actual debug logs showing the duplicate uevents. **Minor**: The commit message has a typo: "fully **relay** on userspace" should be "fully **rely** on userspace". The added comment block in the code is verbose but reasonable given the non-obvious interaction between these two notification mechanisms. After this patch, the `status` variable and `dw_hdmi_phy_read_hpd()` call are removed from `dw_hdmi_hpd_work()`, simplifying it to just the `drm_helper_hpd_irq_event()` call. Clean. --- Generated by Claude Code Patch Reviewer