From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: samples: rust: rust_driver_pci: use HRT lifetime for Bar
Date: Mon, 18 May 2026 16:24:35 +1000
Message-ID: <review-patch21-20260517000149.3226762-22-dakr@kernel.org>
In-Reply-To: <20260517000149.3226762-22-dakr@kernel.org>
References: <20260517000149.3226762-1-dakr@kernel.org> <20260517000149.3226762-22-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Major rewrite demonstrating the end-to-end improvement. Before: the sample =
driver needed `Arc`, `Devres`, `RevocableMutex`, `ARef`, and `PinnedDrop`. =
After:

```rust
+struct SampleDriverData<'bound> {
+    _bar: pci::Bar<'bound>,
+    dev: &'bound pci::Device<Bound>,
+}
```

The `probe` function is dramatically simpler =E2=80=94 no manual devres reg=
istration, no revocable wrappers:

```rust
+    fn probe<'bound>(
+        dev: &'bound mut pci::Device<Bound>,
+        _info: &pci::DeviceId,
+    ) -> Result<Pin<KBox<SampleDriverData<'bound>>>> {
+        let bar =3D dev.iomap_region_sized::<{ SampleDriver::MEM_SIZE }>(0=
)?;
+        dev_info!(dev.as_ref(), "PCI base address: {:p}\n", bar.io_addr());
+        KBox::try_pin_init(try_pin_init!(SampleDriverData {
+            _bar: bar,
+            dev: dev.into(),
+        }), GFP_KERNEL)
+    }
```

This is the best demonstration of the series' value. The code is clearer, s=
afer (compile-time vs. runtime checks), and shorter.

---
Generated by Claude Code Patch Reviewer