From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi_qp: Switch to dw_hdmi_qp_hpd_notify() Date: Mon, 25 May 2026 21:15:07 +1000 Message-ID: In-Reply-To: <20260520-dw-hdmi-qp-scramb-v6-21-24b74603b782@collabora.com> References: <20260520-dw-hdmi-qp-scramb-v6-0-24b74603b782@collabora.com> <20260520-dw-hdmi-qp-scramb-v6-21-24b74603b782@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean migration from `drm_helper_hpd_irq_event()` (which polls all connectors) to the targeted `dw_hdmi_qp_hpd_notify()`. Also removes the `drm_probe_helper.h` include that's no longer needed. **Observation**: The old code had a `if (drm)` guard before calling `drm_helper_hpd_irq_event()`. The new code calls `dw_hdmi_qp_hpd_notify(hdmi->hdmi)` unconditionally. Inside `dw_hdmi_qp_hpd_notify()`, it accesses `hdmi->phy.ops->read_hpd()` without checking if the bridge is fully initialized. In the HPD work function context, this should be safe because the work is only scheduled after IRQ registration, which is after bind. In the resume path, `dw_hdmi_qp_resume()` calls `dw_hdmi_qp_init_hw()` first, so the hardware is ready. This looks safe. --- Generated by Claude Code Patch Reviewer