From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dpu: invert the order of UBWC checks Date: Mon, 25 May 2026 21:42:01 +1000 Message-ID: In-Reply-To: <20260520-ubwc-rework-v5-21-72f2749bc807@oss.qualcomm.com> References: <20260520-ubwc-rework-v5-0-72f2749bc807@oss.qualcomm.com> <20260520-ubwc-rework-v5-21-72f2749bc807@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Inverts the DPU SSPP UBWC version checks from exact-match ascending to `>=` descending: ```c - if (ctx->ubwc->ubwc_enc_version == UBWC_1_0) { + if (ctx->ubwc->ubwc_enc_version > UBWC_6_0) { + DRM_WARN_ONCE("Unsupported UBWC version %x\n", ...); + } else if (ctx->ubwc->ubwc_enc_version >= UBWC_5_0) { ... + } else if (ctx->ubwc->ubwc_enc_version >= UBWC_1_0) { ``` Good change. The old exact-match pattern would silently fall through for any minor version (like UBWC_3_1). The inverted `>=` chain handles new minor versions transparently. Also adds a `DRM_WARN_ONCE` for versions above 6.0. **Note:** initializes `ctrl_val = 0` at declaration, which is needed because the new code flow may reach the write without going through any branch (if `> UBWC_6_0`). Correct. --- Generated by Claude Code Patch Reviewer