From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Date: Thu, 04 Jun 2026 14:07:00 +1000 Message-ID: In-Reply-To: <20260601-dd-maint-2-v3-21-4a15b241bd3c@gmail.com> References: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> <20260601-dd-maint-2-v3-21-4a15b241bd3c@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The `dd_set_module_subrange` macro is complex but well-documented. It uses statement-expression `({ })` syntax and a temporary `__start` variable to avoid modifying the iteration pointer. The `INIT_LIST_HEAD(&dt->link)` removal appears to be a bug -- the list_head should still be initialized before `list_add_tail`. Let me check... actually, `kzalloc` zeroes the struct, and `list_add_tail` doesn't require pre-initialization since it directly sets both `next` and `prev`. So this is technically safe, though `INIT_LIST_HEAD` is conventional. --- Generated by Claude Code Patch Reviewer