From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: dw_hdmi_qp: Implement .{enable|disable}_hpd() PHY ops Date: Thu, 04 Jun 2026 13:33:50 +1000 Message-ID: In-Reply-To: <20260602-dw-hdmi-qp-scramb-v7-21-445eb54ee1ed@collabora.com> References: <20260602-dw-hdmi-qp-scramb-v7-0-445eb54ee1ed@collabora.com> <20260602-dw-hdmi-qp-scramb-v7-21-445eb54ee1ed@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Good refactoring =E2=80=94 consolidates interrupt management from scattered= open-coded register writes into dedicated functions. Note that the threade= d IRQ handler now calls `enable_hpd(NULL, hdmi)` with `dw_hdmi` parameter a= s NULL. The functions only use the `data` parameter (cast to `rockchip_hdmi= _qp`), so the NULL `dw_hdmi` is unused and safe, but it's a code smell. Con= sider whether the function signature should be adjusted. --- Generated by Claude Code Patch Reviewer