From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Document bridge chain format selection Date: Wed, 25 Mar 2026 06:44:31 +1000 Message-ID: In-Reply-To: <20260324-color-format-v11-22-605559af4fb4@collabora.com> References: <20260324-color-format-v11-0-605559af4fb4@collabora.com> <20260324-color-format-v11-22-605559af4fb4@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Good documentation addition explaining the recursive format selection algor= ithm and how display drivers should consume it. No issues. --- **Summary of actionable items:** 1. **Bug (patch 8, i915 DP-MST):** `actual_format` can be used uninitialize= d if `pipe_config->output_format` hits an unexpected value =E2=80=94 add `d= efault:` case. 2. **Style (patches 3):** `hdmi_colorformats` and `dp_colorformats` are ide= ntical =E2=80=94 consolidate or add a comment explaining why they're separa= te. 3. **Fragile pattern (patch 8):** Using `!req_fmt` to mean AUTO relies on e= num value being 0 =E2=80=94 prefer explicit `=3D=3D DRM_CONNECTOR_COLOR_FOR= MAT_AUTO`. 4. **Behavioral change (patch 8):** Dropped `has_hdmi_sink` check in i915 H= DMI fallback =E2=80=94 verify `ycbcr_420_allowed` covers all cases. 5. **Typo (patch 5):** `"bits per compoennt"` in kerneldoc. 6. **Duplication (patches 4, 6, 8, 9):** The `DRM_OUTPUT_COLOR_FORMAT_*` = =E2=86=94 `DRM_CONNECTOR_COLOR_FORMAT_*` conversion switch appears multiple= times =E2=80=94 a shared inline converter function would reduce maintenanc= e risk. --- Generated by Claude Code Patch Reviewer