From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Date: Sun, 12 Apr 2026 12:51:29 +1000 Message-ID: In-Reply-To: <20260408084239.1295325-23-ankit.k.nautiyal@intel.com> References: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> <20260408084239.1295325-23-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Extends `intel_dp_link_training_set_mode()` with a `pr_with_as_sdp_enable` parameter to set `DP_FIXED_VTOTAL_AS_SDP_EN_IN_PR_ACTIVE` in DPCD 0x107. Updates all callers. The condition in `intel_dp_update_downspread_ctrl()`: ```c bool pr_with_as_sdp_enable = intel_psr_needs_alpm_aux_less(intel_dp, crtc_state) && crtc_state->infoframes.enable & intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC); ``` Missing parentheses around the `&` expression could be confusing since `&` has lower precedence than `&&`. While it evaluates correctly due to the left-to-right evaluation and the bitwise result being implicitly converted to bool, adding explicit parentheses would improve readability: ```c (crtc_state->infoframes.enable & intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC)) ``` Missing R-b. --- Generated by Claude Code Patch Reviewer