From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Merge top and bottom half IRQ handlers Date: Mon, 18 May 2026 16:41:50 +1000 Message-ID: In-Reply-To: <20260516183838.2024991-23-jonas@kwiboo.se> References: <20260516183838.2024991-1-jonas@kwiboo.se> <20260516183838.2024991-23-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status:** Correct. Since the bottom half only calls `mod_delayed_work()` (which is IRQ-safe), there's no need for a threaded IRQ handler. The merge into `dw_hdmi_hardirq()` is clean: ```c - ret = devm_request_threaded_irq(dev, irq, dw_hdmi_hardirq, - dw_hdmi_irq, IRQF_SHARED, - dev_name(dev), hdmi); + ret = devm_request_irq(dev, irq, dw_hdmi_hardirq, IRQF_SHARED, + dev_name(dev), hdmi); ``` The ACK/unmute of the PHY interrupt is now done conditionally only when HPD is actually handled, which is slightly cleaner. The `intr_stat` write is moved inside the `if (intr_stat)` block to avoid unnecessary register writes. **Series looks good for merge.** The only patch lacking review tags is 14/22 (bridge detect EDID update) and 15/22 (bridge CEC notifier support), both new in v6. --- Generated by Claude Code Patch Reviewer