From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: dw-hdmi-qp: Remove obsolete .setup_hpd() phy op Date: Mon, 25 May 2026 21:15:07 +1000 Message-ID: In-Reply-To: <20260520-dw-hdmi-qp-scramb-v6-22-24b74603b782@collabora.com> References: <20260520-dw-hdmi-qp-scramb-v6-0-24b74603b782@collabora.com> <20260520-dw-hdmi-qp-scramb-v6-22-24b74603b782@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean removal of the now-unused `setup_hpd` callback from both the bridge driver and the header. All callers have been migrated to `enable_hpd`/`disable_hpd` in previous patches. --- **Summary**: This is a mature, well-decomposed v6 series. The architecture is sound, error handling is thorough, and the series has good test coverage (multiple Tested-by tags). The main substantive items are: (1) the C++ style `// TODO` comment in patch 4 should use `/* */`, and (2) the `scdc_cb` pointer access ordering relies on `cancel_delayed_work_sync()` guarantees that could benefit from a brief comment. Otherwise this looks ready for merge, assuming the maintainer (Maxime Ripard for the DRM HDMI framework parts) is happy with the connector/bridge interface additions. --- Generated by Claude Code Patch Reviewer