From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: ubwc: sort out the rest of the UBWC swizzle settings Date: Mon, 09 Mar 2026 08:32:19 +1000 Message-ID: In-Reply-To: <20260306-ubwc-rework-v1-23-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> <20260306-ubwc-rework-v1-23-9cfdff12f2bb@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes the `ubwc_swizzle` field entirely, replacing it with `flags` field using `UBWC_FLAG_DISABLE_SWIZZLE_LVL2` and `UBWC_FLAG_DISABLE_SWIZZLE_LVL3`. The helper now defaults to levels 2+3 enabled and only checks flags for exceptions: ```c + u32 ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 | + UBWC_SWIZZLE_ENABLE_LVL3; + + if (cfg->flags & UBWC_FLAG_DISABLE_SWIZZLE_LVL2) + ubwc_swizzle &= ~UBWC_SWIZZLE_ENABLE_LVL2; ``` Only `sa8775p_data` needs `UBWC_FLAG_DISABLE_SWIZZLE_LVL2` and `glymur_data` needs both disable flags. Good design -- flags for the exceptional cases rather than storing the common default. --- Generated by Claude Code Patch Reviewer