From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Date: Sun, 12 Apr 2026 12:51:30 +1000 Message-ID: In-Reply-To: <20260408084239.1295325-24-ankit.k.nautiyal@intel.com> References: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> <20260408084239.1295325-24-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **R-b: Ville Syrjala** Correctly sets the AS SDP operation mode: - CMRR: `DP_AS_SDP_FAVT_TRR_REACHED` - VRR: `DP_AS_SDP_AVT_DYNAMIC_VTOTAL` - Fixed (PR link-off, no VRR): `DP_AS_SDP_AVT_FIXED_VTOTAL` The redundant `as_sdp->target_rr = 0;` is removed since `target_rr` is zero-initialized and only set in the CMRR path. No issues. --- Generated by Claude Code Patch Reviewer