From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dyndbg: change __dynamic_func_call_cls* macros into expressions Date: Thu, 04 Jun 2026 14:07:01 +1000 Message-ID: In-Reply-To: <20260601-dd-maint-2-v3-23-4a15b241bd3c@gmail.com> References: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> <20260601-dd-maint-2-v3-23-4a15b241bd3c@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Important fix for Xe driver's `XE_IOCTL_DBG` pattern that uses `drm_dbg()` inside an if-expression. Converting `do { } while(0)` to `({ })` is the standard solution. The `0;` return value matching `no_printk` is correct. The `dynamic_hex_dump` fallback stub also gets converted. No issues. --- Generated by Claude Code Patch Reviewer