From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dyndbg: change __dynamic_func_call_cls* macros into expressions Date: Thu, 04 Jun 2026 12:12:51 +1000 Message-ID: In-Reply-To: <20260602-dd-maint-2-v4-23-19a1445585a8@gmail.com> References: <20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com> <20260602-dd-maint-2-v4-23-19a1445585a8@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **This fixes a real DRM/Xe build issue** where `XE_IOCTL_DBG` uses `drm_dbg()` inside an `if` expression. The fix converts `do { ... } while (0)` to `({ ... 0; })` statement expressions. The `0;` return value matches `no_printk`'s return value, which is correct. The `dynamic_hex_dump` disabled fallback is also converted for consistency. This patch is clean and correct. Has Reviewed-by from Louis Chauvet. --- Generated by Claude Code Patch Reviewer