From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: ubwc: drop macrotile_mode from the database Date: Fri, 13 Mar 2026 14:12:52 +1000 Message-ID: In-Reply-To: <20260312-ubwc-rework-v3-24-b7e8f800176a@oss.qualcomm.com> References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> <20260312-ubwc-rework-v3-24-b7e8f800176a@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Potential issue:** `sc8180x_data` previously had `.macrotile_mode = true` with `UBWC_3_0`. This patch removes `macrotile_mode` but keeps sc8180x at `UBWC_3_0` (unlike sc7280/sar2130p which are bumped to `UBWC_3_1`). This means sc8180x loses its macrotile mode setting. If the old `macrotile_mode = true` was correct for sc8180x, its version should be bumped to `UBWC_3_1`. If the old value was wrong, the commit message should explicitly note this correction. This is the most significant concern in the series and the patch notably lacks a Reviewed-by tag. --- Generated by Claude Code Patch Reviewer