From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Date: Sun, 12 Apr 2026 12:51:30 +1000 Message-ID: In-Reply-To: <20260408084239.1295325-25-ankit.k.nautiyal@intel.com> References: <20260408084239.1295325-1-ankit.k.nautiyal@intel.com> <20260408084239.1295325-25-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the key architectural patch. The AS SDP computation is split: - Early (`intel_dp_compute_as_sdp()`): only sets the `infoframes.enable` bit - Late (`intel_dp_as_sdp_compute_config_late()`): fills in all actual AS SDP fields This is needed because the guardband calculation (which runs between these phases) needs to know whether AS SDP is enabled, but the AS SDP fields themselves depend on feature decisions made later. The function `intel_dp_sdp_compute_config_late()` now takes `intel_dp` as a parameter to pass through to `intel_dp_as_sdp_compute_config_late()`. Sound design. Missing R-b. --- Generated by Claude Code Patch Reviewer