From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: drm: tyr: use HRT lifetime for IoMem
Date: Tue, 28 Apr 2026 13:47:59 +1000
Message-ID: <review-patch24-20260427221155.2144848-25-dakr@kernel.org>
In-Reply-To: <20260427221155.2144848-25-dakr@kernel.org>
References: <20260427221155.2144848-1-dakr@kernel.org> <20260427221155.2144848-25-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Excellent cleanup for Tyr. Register reads/writes become infallible since the `IoMem` is used directly during probe rather than through `Devres`. The `Register::read` returns `u32` instead of `Result<u32>`, and `Register::write` returns `()` instead of `Result`. The note about not being updated to the `register!()` macro is appropriate.

---
Generated by Claude Code Patch Reviewer