From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dynamic_debug: use KBUILD_MODFILE for unique builtin module names Date: Thu, 04 Jun 2026 14:07:01 +1000 Message-ID: In-Reply-To: <20260601-dd-maint-2-v3-24-4a15b241bd3c@gmail.com> References: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com> <20260601-dd-maint-2-v3-24-4a15b241bd3c@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The most impactful user-visible change. The backward-compatibility via `kbasename()` matching is well-handled: ```c if (query->module && !match_wildcard(query->module, di->mod_name) && !match_wildcard(query->module, kbasename(di->mod_name))) ``` This preserves existing `module main` queries while allowing `module init/main` for precision. The `DDEBUG_MODNAME` ifdef falling back to `KBUILD_MODNAME` for loadable modules is correct since `KBUILD_MODFILE` isn't always defined. The selftest updates are appropriate. The cover letter already explains the deeper motivation (classmap ambiguity prevention). The documentation updates are good. One concern: the cover letter mentions this is patch-25 but it's actually patch 24 in the series -- numbering was likely adjusted between cover letter writing and posting. --- Generated by Claude Code Patch Reviewer