From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: lib/parser: add match_wildcard_hyphen() for agnostic matching
Date: Thu, 04 Jun 2026 12:12:51 +1000
Message-ID: <review-patch24-20260602-dd-maint-2-v4-24-19a1445585a8@gmail.com>
In-Reply-To: <20260602-dd-maint-2-v4-24-19a1445585a8@gmail.com>
References: <20260602-dd-maint-2-v4-0-19a1445585a8@gmail.com> <20260602-dd-maint-2-v4-24-19a1445585a8@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Clean refactoring of `match_wildcard()` into a `__always_inline __match_wildcard()` with a `hyphen_agnostic` parameter. The `dash2underscore()` helper is simple and correct.

The ternary in the comparison is a bit dense:
```c
if (hyphen_agnostic ?
    (dash2underscore(*s) == dash2underscore(*p)) :
    (*s == *p)) {
```
but it's readable enough and `__always_inline` ensures zero overhead for the `hyphen_agnostic=false` case.

---
Generated by Claude Code Patch Reviewer