From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: ubwc: deduplicate UBWC configuration data Date: Thu, 12 Mar 2026 07:21:55 +1000 Message-ID: In-Reply-To: <20260311-ubwc-rework-v2-25-69f718f2a1c9@oss.qualcomm.com> References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> <20260311-ubwc-rework-v2-25-69f718f2a1c9@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Nice final cleanup that reduces ~30 separate `_data` structs to ~15 generic `ubwc_X_Y_hbbN` structs. The `TODO: highest_bank_bit = 15 for LP_DDR4` comments from sm8250/sm8350/sm8550/sm8750 are lost in this deduplication. Consider either keeping these as comments on the compatible string entries, or noting the LP_DDR4 issue in the generic struct definition. There's also a minor whitespace inconsistency: ```c static const struct qcom_ubwc_cfg_data ubwc_3_1_hbb14 = { ``` has a double space before `=`. --- Generated by Claude Code Patch Reviewer