From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/connector: Update docs of "colorspace" for color format prop Date: Sun, 12 Apr 2026 11:01:45 +1000 Message-ID: In-Reply-To: <20260409-color-format-v12-25-ce84e1817a27@collabora.com> References: <20260409-color-format-v12-0-ce84e1817a27@collabora.com> <20260409-color-format-v12-25-ce84e1817a27@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Updates the "colorspace" property documentation to reference the new "color format" property. Clarifies that colorspace controls the colorimetry/gamut while color format controls the output encoding (RGB vs YUV). **Verdict**: Good. --- ## Summary of Action Items 1. **Patch 3**: `dp_colorformats` is identical to `hdmi_colorformats` -- unify or add a comment. 2. **Patch 5**: Typo "compoennt" -> "component" in kerneldoc. 3. **Patch 8**: Use `DRM_CONNECTOR_COLOR_FORMAT_AUTO` instead of `!drm_state->color_format` for clarity. Add a comment explaining the `PIXEL_ENCODING_UNDEFINED` error-signaling mechanism. 4. **Patch 15**: Add braces around the else-if body containing the switch statement. --- Generated by Claude Code Patch Reviewer