From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: drm: tyr: use HRT lifetime for IoMem
Date: Thu, 07 May 2026 13:02:06 +1000
Message-ID: <review-patch25-20260506215113.851360-26-dakr@kernel.org>
In-Reply-To: <20260506215113.851360-26-dakr@kernel.org>
References: <20260506215113.851360-1-dakr@kernel.org> <20260506215113.851360-26-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

The Tyr driver conversion shows the full benefit for register access:
```rust
// Before:
pub(crate) fn read(&self, dev: &Device<Bound>, iomem: &Devres<IoMem>) -> Result<u32> {
    let value = (*iomem).access(dev)?.read32(OFFSET);
    Ok(value)
}
// After:
pub(crate) fn read(&self, iomem: &IoMem) -> u32 {
    iomem.read32(OFFSET)
}
```

Register reads/writes become infallible and require fewer parameters. `GpuInfo::new()` goes from `Result<Self>` to `Self`. This is a significant ergonomic win.

No issues found.

---
Generated by Claude Code Patch Reviewer