From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: unregister sysmem flush page from Drop
Date: Mon, 18 May 2026 16:24:36 +1000
Message-ID: <review-patch25-20260517000149.3226762-26-dakr@kernel.org>
In-Reply-To: <20260517000149.3226762-26-dakr@kernel.org>
References: <20260517000149.3226762-1-dakr@kernel.org> <20260517000149.3226762-26-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Updates `SysmemFlush` to use a borrowed device reference instead of `ARef<Device>`:

```rust
-pub(crate) struct SysmemFlush {
-    dev: ARef<Device>,
+pub(crate) struct SysmemFlush<'bound> {
+    dev: &'bound Device,
```

The `Drop` impl now calls `dev_err!` on the borrowed device, which is valid because `'bound` is still live when the struct is dropped (guaranteed by the binding-scope lifetime). Clean migration.

---
Generated by Claude Code Patch Reviewer