From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: ubwc: drop macrotile_mode from the database Date: Mon, 25 May 2026 21:42:02 +1000 Message-ID: In-Reply-To: <20260520-ubwc-rework-v5-25-72f2749bc807@oss.qualcomm.com> References: <20260520-ubwc-rework-v5-0-72f2749bc807@oss.qualcomm.com> <20260520-ubwc-rework-v5-25-72f2749bc807@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes `qcom_ubwc_macrotile_mode()` to derive the value from version: ```c return cfg->ubwc_enc_version >= UBWC_3_1; ``` This is where `UBWC_3_1` from patch 01 becomes critical. Several SoCs are reclassified: - sc7280: UBWC_3_0 -> UBWC_3_1 (had `macrotile_mode = true`) - sc8180x: UBWC_3_0 -> UBWC_3_1 (had `macrotile_mode = true`) - sar2130p: UBWC_3_0 -> UBWC_3_1 (had `macrotile_mode = true`) While sm8150 stays at UBWC_3_0 (had no macrotile_mode). The version change correctly captures the macrotile_mode distinction. This is the most important semantic change in the series. --- Generated by Claude Code Patch Reviewer