From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tests: bridge: Add KUnit tests for bridge chain format selection Date: Mon, 25 May 2026 17:26:14 +1000 Message-ID: In-Reply-To: <20260523-color-format-v16-25-24340c5e4732@collabora.com> References: <20260523-color-format-v16-0-24340c5e4732@collabora.com> <20260523-color-format-v16-25-24340c5e4732@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The most extensive test patch (787 lines). The macro-based bridge definition system (`DEFINE_FMT_FUNCS_FROM_TUPLES`, `DRM_BRIDGE_ATOMIC_WITH_BUS_FMT`, etc.) is clever and makes it easy to define bridge chains with specific format conversion capabilities. The test cases cover: - RGB-to-YUV-to-RGB conversion chains - Explicit YUV444 format selection through a converting bridge - HDMI AUTO preferring RGB - Non-HDMI AUTO picking first available - No-path error cases Excellent test coverage for the bridge chain format selection logic. --- Generated by Claude Code Patch Reviewer