From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: ubwc: use fixed values for UBWC swizzle for UBWC < 4.0 Date: Mon, 25 May 2026 21:42:02 +1000 Message-ID: In-Reply-To: <20260520-ubwc-rework-v5-26-72f2749bc807@oss.qualcomm.com> References: <20260520-ubwc-rework-v5-0-72f2749bc807@oss.qualcomm.com> <20260520-ubwc-rework-v5-26-72f2749bc807@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves swizzle constants into `qcom_ubwc_swizzle()`: ```c if (cfg->ubwc_enc_version == UBWC_1_0) return UBWC_SWIZZLE_ENABLE_LVL1 | UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3; if (cfg->ubwc_enc_version < UBWC_4_0) return UBWC_SWIZZLE_ENABLE_LVL2 | UBWC_SWIZZLE_ENABLE_LVL3; return cfg->ubwc_swizzle; ``` Removes `ubwc_swizzle` from all per-SoC entries with UBWC < 4.0. The `UBWC_SWIZZLE_ENABLE_*` defines are moved below the struct (they were previously part of the struct's field documentation). The fallthrough to `cfg->ubwc_swizzle` handles UBWC >= 4.0 where per-SoC variation remains. Also removes the `qcom_ubwc_get_ubwc_mode` cross-check that warned about UBWC 1.0 configs missing LVL1 swizzle -- no longer possible since the helper always returns it. Clean and correct. --- Generated by Claude Code Patch Reviewer