From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: drm: tyr: use lifetime for IoMem Date: Mon, 18 May 2026 16:24:36 +1000 Message-ID: In-Reply-To: <20260517000149.3226762-28-dakr@kernel.org> References: <20260517000149.3226762-1-dakr@kernel.org> <20260517000149.3226762-28-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Final patch: updates the Tyr DRM driver to use borrowed device references: ```rust - dev: ARef, + dev: &'bound device::Device, ``` Also updates `TyrDevice` to be lifetime-parameterized: ```rust -struct TyrDevice { +struct TyrDevice<'bound> { regs: Register, - dev: ARef, + dev: &'bound device::Device, ``` Clean migration following the same pattern as nova-core. The `into_devres()= ` is used for `TyrDevice` since it's stored in a `Devres` wrapper for the D= RM subsystem. --- **Summary:** This is a well-executed series that makes a fundamental improv= ement to Rust driver safety in the kernel. The main areas deserving extra s= crutiny from reviewers are: (1) the C-side reordering in patch 4 and its im= pact on existing drivers, (2) the `transmute`-based lifetime erasure in `in= to_devres()` methods, (3) the `ForLt` macro's covariance proof generation, = and (4) the self-referential initialization pattern in nova-core patch 24. = The end result =E2=80=94 as demonstrated by the sample driver rewrite in pa= tch 21 =E2=80=94 is significantly simpler and safer driver code. --- Generated by Claude Code Patch Reviewer