From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: soc: qcom: ubwc: deduplicate UBWC configuration data
Date: Mon, 25 May 2026 21:42:02 +1000
Message-ID: <review-patch28-20260520-ubwc-rework-v5-28-72f2749bc807@oss.qualcomm.com>
In-Reply-To: <20260520-ubwc-rework-v5-28-72f2749bc807@oss.qualcomm.com>
References: <20260520-ubwc-rework-v5-0-72f2749bc807@oss.qualcomm.com> <20260520-ubwc-rework-v5-28-72f2749bc807@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

The payoff patch. Replaces 30+ per-SoC `_data` structs with ~15 generic entries named by version and HBB:

```c
static const struct qcom_ubwc_cfg_data ubwc_1_0_hbb14 = {
    .ubwc_enc_version = UBWC_1_0,
    .highest_bank_bit = 14,
};
```

The `of_device_id` table now maps directly to these generics:

```c
{ .compatible = "qcom,msm8937", .data = &ubwc_1_0_hbb14 },
{ .compatible = "qcom,sm8250",  .data = &ubwc_4_0_hbb16 },
```

Only `sa8775p` and `glymur` retain custom structs (due to their flags). The diff is -120/+76 lines, a net reduction of 44 lines despite adding new generic entries.

**Minor note:** There's a trailing double space in `ubwc_3_1_hbb14` and `ubwc_3_1_hbb16` declarations (cosmetic).

Good final patch that demonstrates the series achieved its goal.

---
Generated by Claude Code Patch Reviewer