From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/connector: Update docs of "colorspace" for color format prop Date: Mon, 25 May 2026 18:49:00 +1000 Message-ID: In-Reply-To: <20260522-color-format-v15-28-21fb136c9df2@collabora.com> References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> <20260522-color-format-v15-28-21fb136c9df2@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Two-line doc update. Correct and necessary. --- **Summary of issues by severity:** **Potential bug:** - Patch 11: `intel_hdmi_can_ycbcr444()` returns `true` only for GMCH platfo= rms, which seems inverted. This affects which connectors advertise YCbCr444= support in patches 11 and 13. **Minor issues:** - Patch 7: Typo "compoennt" in kernel-doc - Patch 8: Dead code =E2=80=94 the `DRM_CONNECTOR_COLOR_FORMAT_AUTO` case i= nside a `!=3D AUTO` guard - Patch 10: Dead switch case in `dm_validate_stream_color_format` due to ea= rly return - Patch 27: Commit message typo ("not sufficiently complex enough" =E2=86= =92 should be "now sufficiently complex enough") **Style/documentation:** - Patch 4: Incomplete kernel-doc (missing Return section) - Patch 20: Silent fallback when `bus_fmt_to_reg` returns error =E2=80=94 c= onsider a warning --- Generated by Claude Code Patch Reviewer