From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: add an API to initialize MST on sink side Date: Sun, 12 Apr 2026 10:16:18 +1000 Message-ID: In-Reply-To: <20260410-msm-dp-mst-v4-29-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-29-b20518dea8de@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Hardcoded 100ms delay**: ```c + if (old_mstm_ctrl) { + drm_dbg_dp(dp->drm_dev, "wait %luus to set DP_MSTM_CTRL set 0\n", + clear_mstm_ctrl_timeout_us); + usleep_range(clear_mstm_ctrl_timeout_us, + clear_mstm_ctrl_timeout_us + 1000); + } ``` A 100ms unconditional sleep to wait for the sink to clear MST state is excessive. The DP spec doesn't mandate a specific delay here. This should either poll for completion or use a shorter delay. At minimum, a comment citing the rationale or spec section would help. --- Generated by Claude Code Patch Reviewer