public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: use designated initializer for exp_info
Date: Wed, 11 Feb 2026 16:59:18 +1000	[thread overview]
Message-ID: <review-patch3-20260209153809.250835-4-jiri@resnulli.us> (raw)
In-Reply-To: <20260209153809.250835-4-jiri@resnulli.us>

Patch Review

**Subject**: `dma-buf: heaps: use designated initializer for exp_info`  
**Files Modified**: `drivers/dma-buf/heaps/cma_heap.c`, `drivers/dma-buf/heaps/system_heap.c`  
**Verdict**: ✅ **Good cleanup** (pure refactoring)

#### Technical Review

Pure refactoring patch to use C99 designated initializers instead of field-by-field assignment.

**Changes in cma_heap.c** (lines 585-598):
```c
-   struct dma_heap_export_info exp_info;
+   struct dma_heap_export_info exp_info = {
+       .name = name,
+       .ops = &cma_heap_ops,
+   };
    ...
-   exp_info.name = name;
-   exp_info.ops = &cma_heap_ops;
    exp_info.priv = cma_heap;
```

**Analysis**:
✅ Modern C style  
✅ Zero-initializes all unspecified fields automatically  
✅ Makes follow-up patches cleaner (PATCH 4 adds new field)  
✅ No functional change  
✅ Reduces lines of code  

**Question**: Why is `exp_info.priv = cma_heap;` kept as separate assignment instead of being in the initializer? 

Answer: Because `cma_heap` is allocated just before (line 591-593), so it's not available at initialization time. This is fine.

**Correctness Check**:
- Before: `exp_info` on stack, uninitialized, then `.name` and `.ops` assigned
- After: `exp_info` on stack, zero-initialized, with `.name` and `.ops` set
- Both: `.priv` assigned later

This is semantically identical. ✅

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-11  6:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09 15:38 [PATCH 0/5] dma-buf: heaps: system: add an option to allocate explicitly decrypted memory Jiri Pirko
2026-02-09 15:38 ` [PATCH 1/5] dma-mapping: avoid random addr value print out on error path Jiri Pirko
2026-02-11  6:59   ` Claude review: " Claude Code Review Bot
2026-02-12 11:03   ` [PATCH 1/5] " Marek Szyprowski
2026-02-12 12:52     ` Jiri Pirko
2026-02-09 15:38 ` [PATCH 2/5] dma-mapping: introduce DMA_ATTR_CC_DECRYPTED for pre-decrypted memory Jiri Pirko
2026-02-11  6:59   ` Claude review: " Claude Code Review Bot
2026-02-09 15:38 ` [PATCH 3/5] dma-buf: heaps: use designated initializer for exp_info Jiri Pirko
2026-02-11  6:59   ` Claude Code Review Bot [this message]
2026-02-09 15:38 ` [PATCH 4/5] dma-buf: heaps: allow heap to specify valid heap flags Jiri Pirko
2026-02-09 20:08   ` John Stultz
2026-02-10  0:29     ` Jason Gunthorpe
2026-02-10  9:14       ` Jiri Pirko
2026-02-10 12:43         ` Jason Gunthorpe
2026-02-10 14:49           ` Jiri Pirko
2026-02-10 14:54             ` Jason Gunthorpe
2026-02-10  9:05     ` Jiri Pirko
2026-02-10 12:48       ` Leon Romanovsky
2026-02-10 20:05         ` John Stultz
2026-02-11  6:59   ` Claude review: " Claude Code Review Bot
2026-02-09 15:38 ` [PATCH 5/5] dma-buf: heaps: system: add an option to allocate explicitly decrypted memory Jiri Pirko
2026-02-10 12:02   ` kernel test robot
2026-02-10 18:03   ` kernel test robot
2026-02-11  6:59   ` Claude review: " Claude Code Review Bot
2026-02-11  6:59 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260209153809.250835-4-jiri@resnulli.us \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox